etcdserver: strip patch version in metrics #11265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strip patch version in cluster version metrics during node restart.
|
cc @gyuho @wenjiaswe |
|
lgtm, thanks! |
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Oct 16, 2019
gyuho
approved these changes
Oct 16, 2019
gyuho
added a commit
that referenced
this pull request
Oct 16, 2019
…5-upstream-release-3.4 Automated cherry pick of #11265 on release 3.4
wenjiaswe
added a commit
to wenjiaswe/etcd
that referenced
this pull request
Oct 17, 2019
hexfusion
pushed a commit
to openshift/etcd
that referenced
this pull request
Mar 20, 2020
hexfusion
pushed a commit
to openshift/etcd
that referenced
this pull request
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes #11254.
For example, if node starts / restarts with existing data dir (which stores cluster version), it goes through this code path. Found in #11261.