-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG: Add v3.4.3 #11354
CHANGELOG: Add v3.4.3 #11354
Conversation
Add v3.4.3 and fix v3.4.2 release date. Fixes # 11353
Codecov Report
@@ Coverage Diff @@
## master #11354 +/- ##
==========================================
- Coverage 64.88% 64.27% -0.62%
==========================================
Files 403 403
Lines 37969 37969
==========================================
- Hits 24637 24404 -233
- Misses 11707 11922 +215
- Partials 1625 1643 +18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just noticed we are missing changelog updates from #11184 and #11211. They are backported to v3.4.2 and v3.3.16. Context: |
@jingyih ahh :-) I searched for only 3.4.3 changes. I will add them unless you are adding. Thanks! |
Please go ahead:) |
:) sounds good, thanks @jingyih |
@jingyih hi, so these both needs to be added in changlog for 3.4.2, 3.3.16 and also 3.5 right? I don't see it's been added anywhere. |
Yes. I believe they are missing in all change logs. |
OK, thanks @jingyih !! |
Add v3.4.3 and fix v3.4.2 release date.
Fixes #11353