Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Add v3.4.3 #11354

Merged
merged 1 commit into from
Nov 13, 2019
Merged

CHANGELOG: Add v3.4.3 #11354

merged 1 commit into from
Nov 13, 2019

Conversation

spzala
Copy link
Member

@spzala spzala commented Nov 13, 2019

Add v3.4.3 and fix v3.4.2 release date.

Fixes #11353

Add v3.4.3 and fix v3.4.2 release date.

Fixes # 11353
@spzala spzala requested review from gyuho and jingyih November 13, 2019 19:32
@codecov-io
Copy link

Codecov Report

Merging #11354 into master will decrease coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11354      +/-   ##
==========================================
- Coverage   64.88%   64.27%   -0.62%     
==========================================
  Files         403      403              
  Lines       37969    37969              
==========================================
- Hits        24637    24404     -233     
- Misses      11707    11922     +215     
- Partials     1625     1643      +18
Impacted Files Coverage Δ
client/client.go 48.03% <0%> (-35.95%) ⬇️
proxy/grpcproxy/register.go 69.44% <0%> (-25%) ⬇️
client/members.go 65.32% <0%> (-20.17%) ⬇️
pkg/transport/timeout_conn.go 60% <0%> (-20%) ⬇️
etcdserver/api/v3rpc/util.go 51.61% <0%> (-16.13%) ⬇️
pkg/tlsutil/tlsutil.go 86.2% <0%> (-6.9%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
etcdserver/api/v3rpc/lease.go 69.31% <0%> (-5.69%) ⬇️
pkg/logutil/zap_grpc.go 47.61% <0%> (-4.77%) ⬇️
clientv3/leasing/cache.go 87.77% <0%> (-3.89%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d05459e...8adebf4. Read the comment docs.

Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spzala
Copy link
Member Author

spzala commented Nov 13, 2019

Thanks @jingyih
Merging it /cc @gyuho

@spzala spzala merged commit 63dd73c into etcd-io:master Nov 13, 2019
@jingyih
Copy link
Contributor

jingyih commented Nov 13, 2019

Just noticed we are missing changelog updates from #11184 and #11211. They are backported to v3.4.2 and v3.3.16.

Context:
#11184 fixes kubernetes/kubernetes#83028
#11211 fixes kubernetes/kubernetes#83550

@spzala
Copy link
Member Author

spzala commented Nov 13, 2019

@jingyih ahh :-) I searched for only 3.4.3 changes. I will add them unless you are adding. Thanks!

@jingyih
Copy link
Contributor

jingyih commented Nov 13, 2019

@jingyih ahh :-) I searched for only 3.4.3 changes. I will add them unless you are adding. Thanks!

Please go ahead:)

@spzala
Copy link
Member Author

spzala commented Nov 14, 2019

:) sounds good, thanks @jingyih

@spzala
Copy link
Member Author

spzala commented Nov 14, 2019

Just noticed we are missing changelog updates from #11184 and #11211. They are backported to v3.4.2 and v3.3.16.

Context:
#11184 fixes kubernetes/kubernetes#83028
#11211 fixes kubernetes/kubernetes#83550

@jingyih hi, so these both needs to be added in changlog for 3.4.2, 3.3.16 and also 3.5 right? I don't see it's been added anywhere.

@jingyih
Copy link
Contributor

jingyih commented Nov 14, 2019

Just noticed we are missing changelog updates from #11184 and #11211. They are backported to v3.4.2 and v3.3.16.
Context:
#11184 fixes kubernetes/kubernetes#83028
#11211 fixes kubernetes/kubernetes#83550

@jingyih hi, so these both needs to be added in changlog for 3.4.2, 3.3.16 and also 3.5 right? I don't see it's been added anywhere.

Yes. I believe they are missing in all change logs.

@spzala
Copy link
Member Author

spzala commented Nov 14, 2019

OK, thanks @jingyih !!

spzala added a commit to spzala/etcd that referenced this pull request Dec 2, 2019
spzala added a commit to spzala/etcd that referenced this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CHANGELOG-3.4 missing entries
3 participants