Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump go-systemd to v22.0.0 to fix mod tidy error #11387

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

ms2008
Copy link
Contributor

@ms2008 ms2008 commented Nov 23, 2019

go-systemd had completed of switching to Go modules between v21 and v22.0.0.
This pr fix mod error due to semver not being applied correctly.
Ref. coreos/go-systemd#321

Fixes #11345

@codecov-io
Copy link

codecov-io commented Nov 23, 2019

Codecov Report

Merging #11387 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11387      +/-   ##
==========================================
+ Coverage   64.45%   64.57%   +0.12%     
==========================================
  Files         403      403              
  Lines       37998    37998              
==========================================
+ Hits        24490    24537      +47     
+ Misses      11873    11826      -47     
  Partials     1635     1635
Impacted Files Coverage Δ
etcdmain/main.go 0% <ø> (ø) ⬆️
pkg/logutil/zap_journal.go 6.45% <ø> (ø) ⬆️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
clientv3/concurrency/mutex.go 62.16% <0%> (-5.41%) ⬇️
proxy/grpcproxy/watcher.go 89.79% <0%> (-4.09%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
clientv3/leasing/txn.go 88.09% <0%> (-3.18%) ⬇️
clientv3/balancer/resolver/endpoint/endpoint.go 82.6% <0%> (-1.74%) ⬇️
pkg/netutil/netutil.go 68.85% <0%> (-1.64%) ⬇️
auth/options.go 91.25% <0%> (-1.25%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d7ad3...8e29f8a. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Dec 3, 2019

@ms2008

can you squash the two commits into one?

@ms2008
Copy link
Contributor Author

ms2008 commented Dec 3, 2019

Fixed, thanks.

@xiang90
Copy link
Contributor

xiang90 commented Dec 4, 2019

@ms2008 can you run etcd/scripts/updatebom.sh to update the bill of materials

@ms2008
Copy link
Contributor Author

ms2008 commented Dec 5, 2019

@xiang90 done

@xiang90
Copy link
Contributor

xiang90 commented Dec 5, 2019

lgtm

@xiang90 xiang90 merged commit fd2dddb into etcd-io:master Dec 5, 2019
@ms2008 ms2008 deleted the bump-go-systemd branch December 5, 2019 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

cannot find module providing package github.com/coreos/go-systemd/journal
3 participants