-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clientv3: simplify grpc dialer usage. #11574
Conversation
…after bumping grpc to 1.26.0.
Codecov Report
@@ Coverage Diff @@
## master #11574 +/- ##
=========================================
- Coverage 64.57% 63.78% -0.8%
=========================================
Files 403 403
Lines 38097 38074 -23
=========================================
- Hits 24600 24284 -316
- Misses 11851 12130 +279
- Partials 1646 1660 +14
Continue to review full report at Codecov.
|
There are a few exposed public method removed. Will this affect client API backward compatibility? |
Most of them are the workaround from #11184. We can safely remove them after bumping into latest gRPC. |
lgtm, can we highlight this fix in CHANGELOG 3.5? thx |
Sure. Will do after merged. |
fix #11519
verified by tests under tests/docker-dns, tests/dorker-dns-srv, tests/docker-static-ip
@jpbetz @gyuho