-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mvcc: reduce count-only range overhead #11771
mvcc: reduce count-only range overhead #11771
Conversation
449baa2
to
498291b
Compare
Codecov Report
@@ Coverage Diff @@
## master #11771 +/- ##
==========================================
- Coverage 66.92% 66.83% -0.10%
==========================================
Files 403 403
Lines 36868 36881 +13
==========================================
- Hits 24675 24649 -26
- Misses 10706 10740 +34
- Partials 1487 1492 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea. Not sure if we want to change the existing function signature or create a new method. If the request is for count, can we create a method CountRevisions
?
yes,it will be more clear and concise. I will take the time to update pr. |
e815396
to
2ecbcb8
Compare
@jingyih updated. PTAL. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@tangcong Curious, what's your use case for counting API? |
Low frequency use, but we benefit a lot from it:
|
@tangcong Makes sense. Thanks! |
if there are too much keys(> 1 millions),count-only range is very slow(slice expansion) and cost too much memory. it is not necessary to return revpairs,so we can do a small optimization to reduce overhead.