Automated cherry pick of #11807 #12087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spzala
force-pushed
the
automated-cherry-pick-of-#11807-upstream-release-3.3
branch
2 times, most recently
from
2df9570
to
fcab17d
Compare
|
Also trying to fix the error introduced under #12078 |
spzala
force-pushed
the
automated-cherry-pick-of-#11807-upstream-release-3.3
branch
2 times, most recently
from
bf434af
to
76c988e
Compare
Handle the related panic and clarify doc.
spzala
force-pushed
the
automated-cherry-pick-of-#11807-upstream-release-3.3
branch
from
76c988e
to
abd80f3
Compare
spzala
commented
Jun 27, 2020
| invalidCosts := [2]int{bcrypt.MinCost - 1, bcrypt.MaxCost + 1} | ||
| for _, invalidCost := range invalidCosts { | ||
| as := NewAuthStore(b, nil, tp, invalidCost) | ||
| if as.BcryptCost() != bcrypt.DefaultCost { |
There was a problem hiding this comment.
3.3 doesn't have this func BcryptCost()
|
The build failure is not related and a known flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #11807 on release-3.3.
#11807: wal: fix panic when decoder not set