clientv3/integration: Reduce flakines of TestGetTokenWithoutAuth #12200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
force-pushed
the
20200804-TestGetTokenWithoutAuth
branch
from
fb9124a
to
a03f57f
Compare
The test is vary flaky on Travis. Seems that since (etcd-io#7724) the client is expected to simply ignore whether server is in AuthDisabled mode even if the user supplies credentials. The tests used to: * use very large cluster (10 nodes) * set very low timeout (1 sec) Such setup led to frequent deadlineExceed errors or following failures: === RUN TestGetTokenWithoutAuth {"level":"warn","ts":"2020-08-04T16:50:48.686+0200","caller":"clientv3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"endpoint://client-35573307-1ee5-441b-acc7-d073f0bd7de5/localhost:69820396562031027440","attempt":0,"error":"rpc error: code = Unavailable desc = etcdserver: leader changed"} user_test.go:151: other errors:etcdserver: leader changed --- FAIL: TestGetTokenWithoutAuth (10.91s)
ptabor
force-pushed
the
20200804-TestGetTokenWithoutAuth
branch
from
a03f57f
to
dcce80f
Compare
|
\cc @jingyih - could you, pls, review / merge |
lavacat
pushed a commit
to lavacat/etcd
that referenced
this pull request
Jun 18, 2022
backport from branch-3.5: etcd-io#12200
lavacat
pushed a commit
to lavacat/etcd
that referenced
this pull request
Jun 27, 2022
…ithoutAuth backport from branch-3.5: etcd-io#12200 Signed-off-by: Bogdan Kanivets <[email protected]>
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Sep 8, 2022
…ithoutAuth backport from branch-3.5: etcd-io#12200 Signed-off-by: Bogdan Kanivets <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is vary flaky on Travis.
Seems that since (#7724) the
client is expected to simply ignore whether server is in AuthDisabled
mode even if the user supplies credentials.
The tests used to:
Such setup led to frequent deadlineExceed errors or following failures:
The flakiness is hard to spot when executing isolated:
But is visible when all tests are executed:
GOARCH=amd64 CPU=1 PASSES='integration' ./test --count=3
I believe its due to slowness coming from CPU utilization when multiple tests are executed.