integration: add WatchProgressNotifyInterval in integration test #12271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyih
changed the title
|
cc @wojtek-t |
spzala
reviewed
Sep 6, 2020
wojtek-t
reviewed
Sep 7, 2020
clientv3/integration/watch_test.go
Outdated
| if !resp.IsProgressNotify() { | ||
| t.Fatalf("expected resp.IsProgressNotify() == true") | ||
| } | ||
| case <-time.After(2 * progressInterval): |
There was a problem hiding this comment.
nit: this may be a little flaky in cpu-starved environments, I suggest increasing this a little bit (to at least 1s)
jingyih
force-pushed
the
add_watch_notify_interval_flag_in_testing
branch
from
00b6cb1
to
7fc4364
Compare
jingyih
force-pushed
the
add_watch_notify_interval_flag_in_testing
branch
from
7fc4364
to
73817b5
Compare
|
LGTM - thanks! |
|
@gyuho @jpbetz - would you be able to merge this? IIRC it's blocking cherrypicking back to 3.4, which in turn is blocking https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1904-efficient-watch-resumption (or to be more specific: kubernetes/kubernetes#94364) |
|
LGTM |
jpbetz
added a commit
that referenced
this pull request
Sep 10, 2020
…1-upstream-release-3.4 Automated cherry pick of #12271 on release 3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag
WatchProgressNotifyIntervalwas added to etcdserver in #12216. This PR adds the corresponding flag to integration test so we can utilize it in tests.Fixes #12265