Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yxjetcd pprof UI #12415

Closed
wants to merge 6 commits into from
Closed

Conversation

zhaochen72 and others added 6 commits October 19, 2020 16:48
@yangxuanjia yangxuanjia changed the title Yxjetcd pprof Yxjetcd pprof UI Oct 22, 2020
@ptabor
Copy link
Contributor

ptabor commented Oct 22, 2020

--@tobilarscheid-- @tbg @yangxuanjia
I see this is a clone of cockroachdb code (https://github.com/cockroachdb/cockroach/tree/master/pkg/server/debug/goroutineui).
Assuming we want to incorporate the UI, we should find a better model of sharing the code than copying it.

@tobilarscheid
Copy link
Contributor

Pretty sure I am tagged by mistake :-)

@ptabor
Copy link
Contributor

ptabor commented Oct 22, 2020

I'm sorry about this. I should have tagged @tbg because of these commits: cockroachdb/cockroach@9d7ca0f

@yangxuanjia
Copy link
Contributor Author

yangxuanjia commented Oct 22, 2020

@ptabor
Yes, this feature is good when have problem online, we can easy and quickly troubleshoot. It's wonderful for online system.

@ptabor
Copy link
Contributor

ptabor commented Oct 22, 2020

@yangxuanjia I'm not questioning whether its useful. I just think that etcd community does not want to maintain its own clone of 1kloc maintained in another project. I would propose working with cockrouchdb community for finding a shared location for that code.

@yangxuanjia
Copy link
Contributor Author

yangxuanjia commented Oct 23, 2020

@ptabor you are right, it's better.

@yangxuanjia
Copy link
Contributor Author

@ptabor , Did you interest in #12343 ?

@tbg
Copy link
Contributor

tbg commented Oct 23, 2020

FYI panicparse v2 has this:

https://github.com/maruel/panicparse/blob/master/stack/webstack/webstack.go

You may want to just use that directly. We wrote our code before this was available.

@stale
Copy link

stale bot commented Jan 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 21, 2021
@ptabor
Copy link
Contributor

ptabor commented Jan 31, 2021

Closing this PR, but happy to review integration with library supporting this, e.g. panicparse v2 in a separate PR as Tobis mentioned.

@ptabor ptabor closed this Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants