Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ibm doc #12668

Closed
wants to merge 1 commit into from
Closed

added ibm doc #12668

wants to merge 1 commit into from

Conversation

marifse
Copy link

@marifse marifse commented Feb 4, 2021

  • Added IBM doc setup for etcd

@codecov-io
Copy link

Codecov Report

Merging #12668 (d422c66) into master (6881ea8) will decrease coverage by 6.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12668      +/-   ##
==========================================
- Coverage   57.02%   50.02%   -7.00%     
==========================================
  Files         423      391      -32     
  Lines       32907    31200    -1707     
==========================================
- Hits        18764    15607    -3157     
- Misses      12340    13821    +1481     
+ Partials     1803     1772      -31     
Flag Coverage Δ
all 50.02% <ø> (-7.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/id.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/logutil/zap.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/fileutil/dir_unix.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/fileutil/sync_linux.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/transport/timeout_dialer.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/transport/transport.go 0.00% <0.00%> (-93.34%) ⬇️
pkg/fileutil/read_dir.go 0.00% <0.00%> (-88.89%) ⬇️
pkg/transport/timeout_transport.go 0.00% <0.00%> (-87.50%) ⬇️
server/etcdserver/api/v2store/ttl_key_heap.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/testutil/recorder.go 0.00% <0.00%> (-80.96%) ⬇️
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6881ea8...d422c66. Read the comment docs.

@gyuho
Copy link
Contributor

gyuho commented Feb 9, 2021

@nate-double-u @spzala Could you comment on this?

@nate-double-u
Copy link
Contributor

nate-double-u commented Feb 9, 2021

I mentioned this PR in the docs removal PR as it may be affected by it.

The Documentation folder is largely being removed, so this PR may have to make some changes. Likely a PR into the website repo will have to be made in order to capture the docs change.

@spzala
Copy link
Member

spzala commented Feb 9, 2021

@gyuho it seems like aws doc was added before the etcd project become a CNCF project. IMHO, the maintainers should discuss and decide the project's approach for adding new provider specific doc and its scope. If that sounds good, I will initiate that discussion? That will help us review this PR and any similar future ones. (Any new doc will go to website repo as @nate-double-u mentioned once #12660 is merged so we should discuss doc scope for the website.) Thanks!

@gyuho
Copy link
Contributor

gyuho commented Feb 9, 2021

The Documentation folder is largely being removed

Could you lead us in that direction :)

@marifse Please work with @nate-double-u

@spzala Regarding aws.md, I wouldn't mind removing all platform specific docs, maybe make it generic that are applicable to all platforms.

@spzala
Copy link
Member

spzala commented Feb 9, 2021

The Documentation folder is largely being removed

Could you lead us in that direction :)

@marifse Please work with @nate-double-u

@spzala Regarding aws.md, I wouldn't mind removing all platform specific docs, maybe make it generic that are applicable to all platforms.
@gyuho I am fine with the aws.md, and going forward with your suggestion.

@nate-double-u
Copy link
Contributor

Hi @marifse, we have finished migrating the Documentation to https://github.com/etcd-io/website/, so this PR should be closed and can be recreated in the website repo now.

@ptabor
Copy link
Contributor

ptabor commented Feb 11, 2021

Is there a CNCF requirement to not have solution/platform specific docs/howtos/integration code ?

@nate-double-u
Copy link
Contributor

nate-double-u commented Feb 11, 2021

Is there a CNCF requirement to not have solution/platform specific docs/howtos/integration code ?

No, I don't think there is. DexIdP, for instance, has a whole section on their site showing different platform specific howtos for their connectors.

@ptabor
Copy link
Contributor

ptabor commented Feb 16, 2021

We discussed this on the last community meeting:

I understood (@spzala, @nate-double-u please check if I get this right) goes in following directions:

  • etcd wants to host such "How to style" documents to help our users
  • we recognize that it might be challenging to make sure such documents are kept up-to-data

Thus we are proposing:

I'm closing this PR, as it does not belong to this repo any longer.
But please work with @nate-double-u on putting it in https://github.com/etcd-io/website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants