-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ibm doc #12668
added ibm doc #12668
Conversation
marifse
commented
Feb 4, 2021
- Added IBM doc setup for etcd
Codecov Report
@@ Coverage Diff @@
## master #12668 +/- ##
==========================================
- Coverage 57.02% 50.02% -7.00%
==========================================
Files 423 391 -32
Lines 32907 31200 -1707
==========================================
- Hits 18764 15607 -3157
- Misses 12340 13821 +1481
+ Partials 1803 1772 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@nate-double-u @spzala Could you comment on this? |
I mentioned this PR in the docs removal PR as it may be affected by it. The |
@gyuho it seems like aws doc was added before the etcd project become a CNCF project. IMHO, the maintainers should discuss and decide the project's approach for adding new provider specific doc and its scope. If that sounds good, I will initiate that discussion? That will help us review this PR and any similar future ones. (Any new doc will go to website repo as @nate-double-u mentioned once #12660 is merged so we should discuss doc scope for the website.) Thanks! |
Could you lead us in that direction :) @marifse Please work with @nate-double-u @spzala Regarding aws.md, I wouldn't mind removing all platform specific docs, maybe make it generic that are applicable to all platforms. |
|
Hi @marifse, we have finished migrating the Documentation to https://github.com/etcd-io/website/, so this PR should be closed and can be recreated in the website repo now. |
Is there a CNCF requirement to not have solution/platform specific docs/howtos/integration code ? |
No, I don't think there is. DexIdP, for instance, has a whole section on their site showing different platform specific howtos for their connectors. |
We discussed this on the last community meeting: I understood (@spzala, @nate-double-u please check if I get this right) goes in following directions:
Thus we are proposing:
I'm closing this PR, as it does not belong to this repo any longer. |