-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.5] server,test: refresh cache on each NewAuthStore #14409
Conversation
|
LGTM, the newly added test is a little bit flaky though. If it keeps failing, I think it's valuable to revisit the timeout config. |
Please signoff the commit. You used the github emal Based on the feedback from DCO details, it seems Anyway, could you please get this sorted out? |
This blocks v3.5.5 release. @vivekpatani are you planning to work on this? |
@serathius yes, there is an issue with a flaky test. Sorry, was OoO. @ahrtr @mitake I'm not able to reproduce the issue locally (or inside docker). I can increase the timeout, but I'll have to create another PR to fix that, and then rebase this once that one is merged. But given the fact, I can't reproduce the issue correctly, I'm not sure what timeout needs to be set to. Any recommendations? @ahrtr I'll also look at fixing the signature. The github one is what |
All tests pass apart of DCO, please sign all commits by running |
a113005
to
64992c8
Compare
@serathius I think there's a flaky test, but I've re pushed the fix for DCO. |
- permissions were incorrectly loaded on restarts. - etcd-io#14355 - Backport of etcd-io#14358 Signed-off-by: vivekpatani <[email protected]>
75a01f0
to
7639d93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's investigate the test failure in #14410 |
LGTM, thanks a lot @vivekpatani . Let’s discuss about the flaky test in #14410 |
Signed-off-by: vivekpatani [email protected]
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.