etcdserve: revert the etcdserver side change for the data loss in one node cluster #14505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… node cluster Since the raft side change has been merged, so we need to revert the etcdserver side change. Refer to etcd-io#14413 etcd-io#14400 Signed-off-by: Benjamin Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #14505 +/- ##
==========================================
- Coverage 75.45% 75.19% -0.27%
==========================================
Files 457 457
Lines 37283 37262 -21
==========================================
- Hits 28133 28020 -113
- Misses 7390 7467 +77
- Partials 1760 1775 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Yes, already confirmed the issue can't be reproduced using steps in #14370 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the raft side change #14413 has been merged, so we need to revert the etcdserver side change #14400.
Signed-off-by: Benjamin Wang [email protected]
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cc @serathius @spzala