*: avoid closing a watch with ID 0 incorrectly #14563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kafuu-chino
force-pushed
the
3.5-backport-14296
branch
from
6b3328b
to
7716426
Compare
|
It seems release-3.5 doesn't have |
kafuu-chino
force-pushed
the
3.5-backport-14296
branch
2 times, most recently
from
490e911
to
3477771
Compare
Signed-off-by: Kafuu Chino <[email protected]> add test 1 1 1 1 1 1
kafuu-chino
force-pushed
the
3.5-backport-14296
branch
from
3477771
to
dd983c6
Compare
Yes, there is no client/pkg/v3/verify and the test also has some issues. I have solved them. @ahrtr |
|
@kafuu-chino please add a changelog item for 3.4 and 3.5 respectively. Thanks. |
|
LGTM, thanks @kafuu-chino ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This PR backports #14296 to release-3.5. cc @ahrtr @mitake