Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for CLI flags and add missing flags #16465

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

riendeau
Copy link
Contributor

An attempt to address #16034

Adds a unit test to validate that every (non-ignored) flag defined is present in the help text (either in the usage line or the flags line).

Also adds information on several flags that the unit test identified as missing to the usage text.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test case!

Thanks @riendeau

@ahrtr ahrtr merged commit bcdf055 into etcd-io:main Aug 23, 2023
27 checks passed
@riendeau riendeau deleted the validate-help-flags branch August 23, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants