Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] Introduce the CompactionSleepInterval flag #18514

Merged
merged 1 commit into from
Sep 2, 2024
Merged

[3.5] Introduce the CompactionSleepInterval flag #18514

merged 1 commit into from
Sep 2, 2024

Conversation

JalinWang
Copy link
Contributor

Backport according to #18485 (comment).

This is a cherry-pick of:

  • 184b0e5: add sleep interval
  • fab8474: add CompactionSleepInterval in FakeStore's config
  • 2c53be7 : rename defaultCompactionSleepInterval var

Just for run testing, and I'll squash it later if passed :)

@k8s-ci-robot
Copy link

Hi @JalinWang. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Aug 29, 2024

/ok-to-test

@ArkaSaha30
Copy link
Contributor

This pull request fixes #18481

@ArkaSaha30
Copy link
Contributor

/cc @ivanvc

ivanvc
ivanvc approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Jalin.

Can you please squash your commits? Thanks again.

@AlexStocks @JalinWang
Introduce compaction sleep interval flag
0263597 
This is a backporting cherry-pick of the following commits:

- add flagsline

Signed-off-by: Jalin Wang <[email protected]>

- etcdserver: rename defaultCompactionSleepInterval var (etcd-io#18495)

etcdserver: rename `minimumBatchInterval`  to `defaultCompactionSleepInterval` and `defaultCompactBatchLimit` to `defaultCompactionBatchLimit`

Signed-off-by: Jalin Wang <[email protected]>
(cherry picked from commit 2c53be7)

- test: add CompactionSleepInterval in FakeStore's config

After setting the ComparionSleepInterval, we can use time.Ticker
instead of time.After to optimize the scheduleComparison(),
otherwise it will fail in the 'TestStoreCompact(t)' test.

Signed-off-by: guozhao <[email protected]>
(cherry picked from commit fab8474)

- add sleep interval

(cherry picked from commit 184b0e5)
Signed-off-by: Jalin Wang <[email protected]>
@JalinWang
Copy link
Contributor Author

JalinWang commented Aug 30, 2024 •
edited
Loading

LGTM. Thanks, Jalin.

Can you please squash your commits? Thanks again.

Done~~ Thanks to you and Benjamin for reviewing&approving and ArkaSaha30 for linking the issue. Sorry for the troubles caused by my first-time contribution 🙏

@JalinWang
Copy link
Contributor Author

JalinWang commented Aug 30, 2024 •
edited
Loading

BTW, it seems I should create another PR to update the CHANGELOG in master?

@ivanvc
Copy link
Member

ivanvc commented Aug 30, 2024

@JalinWang, there is nothing to worry about; you're doing awesome :) Yes, please open another PR in the main branch after we merge this. Thanks again.

@ahrtr
Copy link
Member

ahrtr commented Aug 30, 2024

cc @jmhbnz @serathius

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, JalinWang, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 1d4372a into etcd-io:release-3.5 Sep 2, 2024
25 checks passed
@JalinWang JalinWang deleted the backport/release-3.5 branch September 3, 2024 10:00
@ivanvc ivanvc mentioned this pull request Sep 3, 2024
Open
@JalinWang JalinWang mentioned this pull request Sep 9, 2024
Merged
@jmhbnz jmhbnz mentioned this pull request Sep 10, 2024
Closed
2 tasks
aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 25, 2024
@ahrtr @aneesh1
Merge pull request etcd-io#18514 from JalinWang/backport/release-3.5
8cc4346 
[3.5] Introduce the CompactionSleepInterval flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc approved these changes

@serathius serathius serathius approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
approved ok-to-test size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JalinWang @k8s-ci-robot @ivanvc @ArkaSaha30 @ahrtr @serathius @AlexStocks