Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PauseAccept of the reverse proxy from the e2e test #18638

Conversation

henrybear327
Copy link
Contributor

Part of the patches to fix #17737

During the development of #17938, we agreed that during the transition to the L7 forward proxy, unused features and features targeting the L4 reverse proxy will be dropped.

This feature falls under the unused feature.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Part of the patches to fix etcd-io#17737

During the development of etcd-io#17938,
we agreed that during the transition to L7 forward proxy, unused
features and features targeting L4 reverse proxy will be dropped.

This feature falls under the unused feature.

Signed-off-by: Chun-Hung Tseng <[email protected]>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@henrybear327
Copy link
Contributor Author

/cc @serathius

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (1a08fb2) to head (80c1536).

Current head 80c1536 differs from pull request most recent head 3279fb5

Please upload reports for the commit 3279fb5 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
pkg/proxy/server.go 59.71% <100.00%> (-0.90%) ⬇️

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18638      +/-   ##
==========================================
+ Coverage   68.74%   68.76%   +0.02%     
==========================================
  Files         420      420              
  Lines       35535    35502      -33     
==========================================
- Hits        24427    24412      -15     
+ Misses       9677     9663      -14     
+ Partials     1431     1427       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a08fb2...3279fb5. Read the comment docs.

@henrybear327 henrybear327 deleted the fix/e2e_blackhole_proxy_remove_delay_accept branch September 26, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Blackhole failpoint in the proxy does not block all updates
3 participants