fix: use require.NoError instead of t.Fatal(err) in contrib and tools packages

[mmorel-35]

There is no linter for this.
This uses testify instead of testing for
With

require.NoError(t, err)

require.Error(t, err)

instead of

if err != nil {
    t.Fatal(err)
}


if err == nil {
    t.Fatal(err)
}

[k8s-ci-robot]

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (3d6ff97) to head (fa7efc9).

❗ Current head fa7efc9 differs from pull request most recent head 63dad79

Please upload reports for the commit 63dad79 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 29 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18752      +/-   ##
==========================================
- Coverage   68.77%   68.73%   -0.05%     
==========================================
  Files         420      420              
  Lines       35501    35501              
==========================================
- Hits        24416    24400      -16     
- Misses       9657     9670      +13     
- Partials     1428     1431       +3     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d6ff97...63dad79. Read the comment docs.

[ahrtr]

LGTM

Note the we are going to remove raftexample once etcd-io/raft#2 is resovled.

[ahrtr]

/ok-to-test

[fuweid]

LGTM

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment