-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctlv3: close snapshot file before rename (Windows) #6454
Conversation
Does this fix Windows issue in your machine? And commit title? Thanks! |
@gyuho yes, after testing only i have submitted the fix. Its a windows behaviour, if a file is open, then it cannot be renamed or moved or deleted. Thanks! |
@gyuho what do you want me to change the commit title to? |
@sinsharat Yes please. Thanks! |
@gyuho actually i wanted your opinion on what to keep the title. |
@sinsharat How about
|
@gyuho changed. |
@sinsharat Please also change the commit title in git. Tests might fail for different reasons, but not from this patch. Thanks! |
@gyuho changed the title in git. |
lgtm |
This issue was occurring since before renaming, the file was still open as defer was used which would have closed it at the end of the method. The same has been corrected now.
#6451