*: Fix embedded mutexes leaking methods

[s111]

This pull request cleans up all exported structs that were leaking the Lock/Unlock methods from an embedded mutex.

[heyitsanthony]

@s111 is there a linter/tool for detecting this?

[s111]

@heyitsanthony I've written a quick extension of golint for my own use: https://github.com/s111/lint.

[heyitsanthony]

@s111 any way that patch can get into golint upstream or some other linter? If it's a style problem worth fixing I'd like to be able to catch it as part of CI...

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@4301f49). Click here to learn what that means.
The diff coverage is 91.42%.

@@            Coverage Diff            @@
##             master    #7833   +/-   ##
=========================================
  Coverage          ?   75.91%           
=========================================
  Files             ?      332           
  Lines             ?    26177           
  Branches          ?        0           
=========================================
  Hits              ?    19871           
  Misses            ?     4887           
  Partials          ?     1419

Impacted Files	Coverage Δ
raft/storage.go	87.96% <100%> (ø)
pkg/testutil/recorder.go	70.37% <100%> (ø)
etcdserver/stats/leader.go	79.48% <75%> (ø)
etcdserver/stats/server.go	71.66% <75%> (ø)
etcdserver/membership/cluster.go	86.98% <93.33%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4301f49...38d0ebe. Read the comment docs.

[gyuho]

@sebschrader If your patch s111/lint@d196a16 goes in upstream, it would be great.

lgtm. Thanks!

[sebschrader]

Hey @gyuho, you seem to have erroneously mentioned me here.

[gyuho]

@sebschrader Apology! I meant to mention @s111

Thanks!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.