ctlv2: report unhealthy in cluster-health if any node is unavailable #8070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
xiang90
reviewed
Jun 9, 2017
| fmt.Println("cluster is healthy") | ||
| } else { | ||
| case 0: | ||
| fmt.Println("cluster is unavailable") |
There was a problem hiding this comment.
degraded is more descriptive?
heyitsanthony
force-pushed
the
etcdctl-cluster-health
branch
from
79260a0
to
ad0b3cf
Compare
|
lgtm |
heyitsanthony
force-pushed
the
etcdctl-cluster-health
branch
from
36ec217
to
3fcb833
Compare
Codecov Report
@@ Coverage Diff @@
## master #8070 +/- ##
==========================================
- Coverage 76.51% 76.49% -0.03%
==========================================
Files 342 342
Lines 26548 26549 +1
==========================================
- Hits 20314 20309 -5
- Misses 4774 4785 +11
+ Partials 1460 1455 -5
Continue to review full report at Codecov.
|
|
Was this somehow reverted in a recent change? I depend on this behavior here: https://github.com/itskoko/kubecfn/blob/master/kubernetes.yaml#L1049 And cluster-health currently returns 0 even if there are unhealthy/unreachable members: "Container Linux by CoreOS 1688.5.3 (Rhyolite)" |
discordianfish
added a commit
to itskoko/kubecfn
that referenced
this pull request
May 22, 2018
According to etcd-io/etcd#8070, cluster-health should check this but apparently this broke in some recent releases, so we're checking this explicitly in the script now.
|
@discordianfish I see this change is only available from v3.3.0 release https://github.com/coreos/etcd/blob/v3.3.0/etcdctl/ctlv2/command/cluster_health.go? Can you try v3.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8061 and #7032