Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdctl: print "del" instead of "delete" in txn interactive mode #8297

Merged
merged 2 commits into from
Jul 24, 2017

Conversation

fanminshi
Copy link
Member

No description provided.

@gyuho
Copy link
Contributor

gyuho commented Jul 21, 2017

lgtm. /cc @heyitsanthony

Copy link
Contributor

@heyitsanthony heyitsanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bunch of test failures :0

@fanminshi
Copy link
Member Author

fanminshi commented Jul 24, 2017

CI failures #8299

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after test passes.

@fanminshi
Copy link
Member Author

fanminshi commented Jul 24, 2017

jenins-cov reports. I don't think its related. via https://jenkins-etcd-public.prod.coreos.systems/job/etcd-coverage/1784/console

--- FAIL: TestCtlV3PutClientAutoTLS (0.97s)
	ctl_v3_test.go:138: could not start etcd process cluster (read /dev/ptmx: input/output error)

@fanminshi
Copy link
Member Author

https://jenkins-etcd-public.prod.coreos.systems/job/etcd-proxy/2185/console

--- FAIL: TestDoubleTLSClusterSizeOf3 (71.51s)
	cluster.go:268: failed to initialize the etcd server: cannot fetch cluster info from peer urls: could not retrieve cluster information from the given urls

CI failure. Not sure if related.

@heyitsanthony
Copy link
Contributor

unrelated, lgtm

@fanminshi fanminshi merged commit dfd3ef4 into etcd-io:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants