Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: remove SIGQUIT debugging for elect and lock #8355

Merged
merged 1 commit into from
Aug 4, 2017
Merged

e2e: remove SIGQUIT debugging for elect and lock #8355

merged 1 commit into from
Aug 4, 2017

Conversation

heyitsanthony
Copy link
Contributor

No need to read from fd after signalling process to stop and closing
issues an automatic SIGHUP.

gyuho
gyuho approved these changes Aug 2, 2017
View reviewed changes
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@heyitsanthony
Copy link
Contributor Author

I was trying to fix the proxy-ci failure on TestCtlV3Elect, but no luck with this approach it seems.

@heyitsanthony heyitsanthony force-pushed the expect-fd branch 2 times, most recently from f5d0429 to 5072530 Compare August 3, 2017 22:35
@heyitsanthony heyitsanthony changed the title expect: close pty fd before waiting on Stop e2e: remove SIGQUIT debugging for elect and lock Aug 3, 2017
e2e: remove SIGQUIT debugging for elect and lock
5072530 
Causes etcdctl to hang with pending SIGQUIT signals according to
/proc/pid/status. The debugging wasn't very useful on travis
either; just totally remove it to get CI working again.
@heyitsanthony heyitsanthony mentioned this pull request Aug 3, 2017
Closed
@codecov-io
Copy link

Codecov Report

Merging #8355 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8355      +/-   ##
==========================================
+ Coverage   76.68%   76.74%   +0.06%     
==========================================
  Files         349      349              
  Lines       27366    27366              
==========================================
+ Hits        20986    21003      +17     
+ Misses       4868     4857      -11     
+ Partials     1512     1506       -6
Impacted Files Coverage Δ
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
etcdserver/api/v3rpc/lease.go 96.42% <0%> (-3.58%) ⬇️
lease/leasehttp/http.go 62.59% <0%> (-1.53%) ⬇️
etcdserver/cluster_util.go 76.64% <0%> (-1.46%) ⬇️
clientv3/balancer.go 95.08% <0%> (-1.1%) ⬇️
etcdserver/v3_server.go 79.94% <0%> (-0.8%) ⬇️
clientv3/lease.go 91.57% <0%> (-0.77%) ⬇️
clientv3/watch.go 95.04% <0%> (+0.24%) ⬆️
raft/progress.go 96.07% <0%> (+1.96%) ⬆️
pkg/netutil/netutil.go 64.7% <0%> (+2.35%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033c0cb...5072530. Read the comment docs.

gyuho
gyuho approved these changes Aug 4, 2017
View reviewed changes
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@heyitsanthony heyitsanthony merged commit faa4a62 into etcd-io:master Aug 4, 2017
@heyitsanthony heyitsanthony deleted the expect-fd branch August 4, 2017 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyitsanthony @codecov-io @gyuho