Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3: deprecate grpc.ErrClientConnTimeout errors #8505

Merged
merged 3 commits into from
Sep 5, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Sep 5, 2017

Address #8504.

Copy link
Contributor

@heyitsanthony heyitsanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

Endpoints: []string{"http://254.0.0.1:12345"},
DialTimeout: 2 * time.Second
})
err == grpc.ErrClientConnTimeout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if err == grpc.ErrClientConnTimeout {?

Endpoints: []string{"http://254.0.0.1:12345"},
DialTimeout: 2 * time.Second
})
err == context.DeadlineExceeded
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if err == grpc.ErrClientConnTimeout {?

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@9a84c84). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8505   +/-   ##
=========================================
  Coverage          ?   75.66%           
=========================================
  Files             ?      358           
  Lines             ?    29094           
  Branches          ?        0           
=========================================
  Hits              ?    22015           
  Misses            ?     5529           
  Partials          ?     1550
Impacted Files Coverage Δ
clientv3/compare.go 76.66% <0%> (ø)
clientv3/client.go 82.91% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a84c84...8a351f9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants