Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3/integration: add more tests on balancer switch, inflight range #8841

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Nov 8, 2017

Test all possible cases of server shutdown with inflight range requests.
Removed redundant tests in kv_test.go.

c.f. #8711

// the client can switch to other available eps
cli.SetEndpoints(eps...)

if stopPinFirst {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this matters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we stop pinned one first, balancer is expected to switch out of pinned address.
If we stop unpinned one, balancer won't do anything.
With these changes, now we can both cases.

}
}()

time.Sleep(500 * time.Millisecond)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to sleep there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original tests were testing inflight range requests.

@gyuho gyuho force-pushed the test-test branch 8 times, most recently from 3c89a40 to c021e26 Compare November 12, 2017 19:02
@gyuho gyuho force-pushed the test-test branch 3 times, most recently from 96cd8ac to 6328bc5 Compare November 27, 2017 22:39
Test all possible cases of server shutdown with inflight range requests.
Removed redundant tests in kv_test.go.

Signed-off-by: Gyu-Ho Lee <[email protected]>
@gyuho
Copy link
Contributor Author

gyuho commented Nov 30, 2017

Merging this to test new gRPC.
This has been already backported to v3.2 branch.

@gyuho gyuho merged commit 56a012f into etcd-io:master Nov 30, 2017
@gyuho gyuho deleted the test-test branch November 30, 2017 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants