v3rpc: add jitter to progress notification #9278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cw9
reviewed
Feb 5, 2018
etcdserver/api/v3rpc/watch.go
Outdated
| // add rand(1/10*progressReportInterval) as jitter so that etcdserver will not | ||
| // send progress notifications to watchers around the same time even when watchers | ||
| // are created around the same time (which is common when a client restarts itself). | ||
| jitter := time.Duration(rand.Int63n(int64(progressReportInterval) / 10)) |
There was a problem hiding this comment.
Should int64(progressReportInterval) / 10 be done within the Rlock?
There was a problem hiding this comment.
oh. you are right. fixing.
There was a problem hiding this comment.
@cw9 i still keep the rand func out of the lock for good locking practices to minimize the critical section since rand can be expensive.
gyuho
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9246
/cc @cw9