Remove id from dashboard mixin

[serathius]

Grafana provisioned dashboards cannot contain id.
It causes dashboard to be skipped and error in logs

lvl=eror msg="provisioned dashboard json files cannot contain id" logger=provisioning.dashboard type=file name=default

cc @tomwilkie @brancz

[brancz]

Thanks, yes we should remove this. Could you just add a uid to ensure, that the URL is stable? In the kubernetes-mixin we just hashed the name of the dashboard file, so std.md5('etcd.json').

[tomwilkie]

+1

…

On Tue, 26 Jun 2018 at 16:47, Frederic Branczyk ***@***.***> wrote: Thanks, yes we should remove this. Could you just add a uid to ensure, that the URL is stable? In the kubernetes-mixin we just hashed the name of the dashboard file, so std.md5('etcd.json'). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9885 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAbGhbJwML0GSKKZG-eELQkq2MKZlLJvks5uAhhggaJpZM4U3mlT> .

[serathius]

@brancz done

[brancz]

Sorry for forgetting on my last review, could you just re-generate the rendered json manifest as described in this pull request: #9789

Then this lgtm 👍

[serathius]

done

[brancz]

@gyuho has the "debugging" namespace recently been removed? If so @serathius we should make sure this is the same in the mixin, or maybe even configurable, so the mixin is still useful for older versions of etcd.

[gyuho]

@brancz Yes https://github.com/coreos/etcd/pull/9819/files. We should use etcd_mvcc_db_total_size_in_bytes instead. etcd_debugging_mvcc_db_total_size_in_bytes will still be served in 3.4 for backward compatibilities but will be dropped in 3.5.

[brancz]

Thanks for clarifying @gyuho in that case we should make the metric name configurable in the mixin @serathius. Could you add a etcdDbTotalSizeMetric configuration under the top level _config to configure this metric name and have it default to etcd_mvcc_db_total_size_in_bytes. Then downstream users can configure it to the metric name they need. Once 3.5 is out we can then drop the config entirely. Sorry for all the trouble @serathius , I promise once we have that down this lgtm 🙂 .

[hexfusion]

Kind ping @serathius could you please update per @brancz review?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[serathius]

No longer working on it.