Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #9761 #9942

Conversation

wenjiaswe
Copy link
Contributor

Cherry pick of #9761 on release-3.2.

#9761: etcdserver: add "etcd_server_heartbeat_failures_total"

{"level":"warn","ts":1527101858.4149103,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.025771662}
{"level":"warn","ts":1527101858.4149644,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.034015766}

Signed-off-by: Gyuho Lee <[email protected]>
{"level":"warn","ts":1527101858.6985068,"caller":"etcdserver/util.go:115","msg":"apply request took too long","took":0.114101529,"expected-duration":0.1,"prefix":"","request":"header:<ID:1029181977902852337> put:<key:\"\\000\\000...

Signed-off-by: Gyuho Lee <[email protected]>
etcd_mvcc_hash_duration_seconds
etcd_mvcc_hash_rev_duration_seconds

Signed-off-by: Gyuho Lee <[email protected]>
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Jul 20, 2018
@gyuho
Copy link
Contributor

gyuho commented Jul 20, 2018

@wenjiaswe

Can you fix

# github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/mvcc
gopath/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/mvcc/kvstore.go:181: s.kvindex.Keep undefined (type index has no field or method Keep)
gopath/src/github.com/coreos/etcd/cmd/vendor/github.com/coreos/etcd/mvcc/kvstore.go:190: undefined: crc32 in crc32.New

https://semaphoreci.com/coreos/etcd/branches/pull-request-9942/builds/1

Then, should be good to merge.

@wenjiaswe
Copy link
Contributor Author

@gyuho I think I need to carefully backport #8263 before I can backport hashbyrev. Is it safe to backport #8263 to v3.2?

@gyuho
Copy link
Contributor

gyuho commented Jul 20, 2018

How about dropping hash_rev_duration_seconds metric, unless you need it in 3.2? It's only used by endpoint hashkv command, periodic corruption check (still experimental in 3.4), and internal functional testing.

@wenjiaswe
Copy link
Contributor Author

Dropping hash_rev_duration_seconds sounds good to me, I will do that. Thanks!

wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Jul 20, 2018
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @wenjiaswe

@gyuho gyuho merged commit 87418c3 into etcd-io:release-3.2 Jul 20, 2018
gyuho added a commit that referenced this pull request Jul 20, 2018
@wenjiaswe
Copy link
Contributor Author

@jpbetz @jingyih

@wenjiaswe wenjiaswe deleted the automated-cherry-pick-of-#9761-upstream-release-3.2 branch October 15, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants