Add integration tests for gofail #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
from
7805958
to
577c5e3
Compare
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
4 times, most recently
from
8195e54
to
fd562c1
Compare
henrybear327
changed the title
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
from
fd562c1
to
c0dea6d
Compare
|
/cc @ahrtr the code here is now rebased! |
|
Please take a look & fix the workflow failure. |
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
4 times, most recently
from
b2652ba
to
f3490e0
Compare
ahrtr
reviewed
May 22, 2024
|
cc @ArkaSaha30 PTAL |
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
2 times, most recently
from
7f17e8b
to
7ca32e4
Compare
ahrtr
reviewed
May 23, 2024
ArkaSaha30
suggested changes
May 23, 2024
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
3 times, most recently
from
d67e9c6
to
9c2e279
Compare
|
/cc @serathius |
|
@ArkaSaha30 Please ping me back when you finish reviewing this PR. thx |
ArkaSaha30
reviewed
Jun 9, 2024
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
4 times, most recently
from
091bb69
to
ba75e0f
Compare
ahrtr
reviewed
Jun 10, 2024
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
from
fc151a5
to
608d2fe
Compare
ArkaSaha30
approved these changes
Jun 13, 2024
ahrtr
reviewed
Jun 13, 2024
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
from
608d2fe
to
7070b66
Compare
ArkaSaha30
approved these changes
Jun 14, 2024
ahrtr
reviewed
Jun 18, 2024
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
from
6802132
to
66ae3f8
Compare
ahrtr
reviewed
Jun 18, 2024
Closed
Reference: - https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html Signed-off-by: Chun-Hung Tseng <[email protected]> Co-authored-by: Benjamin Wang <[email protected]>
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
from
b24bfeb
to
0a5ef49
Compare
henrybear327
deleted the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
Thanks for all the review comments and suggestions @ahrtr @ArkaSaha30 ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration test for the gofail library.
The idea is to make sure features, such as the one introduced in #65 will not have regression in future changes.