make: ensure phony targets are set #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanvc
force-pushed
the
add-missing-makefile-phony-targets
branch
from
f1eacf8
to
b976bbf
Compare
Ensure the verify and fix Makefile targets are set as PHONY. Signed-off-by: Ivan Valdes <[email protected]>
henrybear327
approved these changes
Sep 16, 2024
ivanvc
force-pushed
the
add-missing-makefile-phony-targets
branch
from
b976bbf
to
9100693
Compare
|
@ivanvc please signoff the commits! |
|
/lgtm |
Done. My bad, I haven't cloned this repo locally and didn't realize my setup wasn't correctly done. 😅 |
ahrtr
approved these changes
Sep 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, henrybear327, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvement: Ensure that
verifyandfixMakefile targets are set as PHONY.