Test: Replace t.error/fatal with assert/request in [node_test.go] #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinyuan Du <[email protected]>
MrDXY
force-pushed
the
replace-test-errors-with-assert-(node_test.go)
branch
from
9a5304a
to
046bcab
Compare
ahrtr
reviewed
Mar 9, 2024
| DescribeEntries(rd.CommittedEntries, func(data []byte) string { return fmt.Sprintf("%q", data) }), | ||
| ) | ||
| } | ||
| assert.False(t, !IsEmptyHardState(rd.HardState) && rd.HardState.Commit < persistedHardState.Commit, |
There was a problem hiding this comment.
nit
Suggested change
| assert.False(t, !IsEmptyHardState(rd.HardState) && rd.HardState.Commit < persistedHardState.Commit, | |
| assert.True(t, IsEmptyHardState(rd.HardState) && rd.HardState.Commit < persistedHardState.Commit, |
There was a problem hiding this comment.
IsEmptyHardState(rd.HardState) || rd.HardState.Commit >= persistedHardState.Commit?
There was a problem hiding this comment.
Overall not a big deal, let's keep it as it's for now. Please feel free to update it in a followup PR if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Replacing t.Error/t.Fatal with assert/require
This commit tries to eliminates boilerplate code in the testing suite by replacing occurrences
of t.Error and t.Fatal with assertions from the assert and require packages.
Changes Made:
Affected Files:
Part of: #146