Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Remove RawNode.TickQuiesced() #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soma00333
Copy link

@soma00333 soma00333 commented Nov 17, 2024

Summary

This PR removes the TickQuiesced() method from the RawNode in the Raft library. This method was deprecated in v3.6.0-alpha.0 and is scheduled for removal in the roadmap for the v4.0.0 release.
To advance the logical clock, please use the Tick() method instead.
Related ticket: #66
Related PR: #62

Changes

  • Removed the TickQuiesced() method from RawNode.

Breaking Change

This PR introduces a breaking change. Any code using TickQuiesced() will no longer compile.

Migration Guide

Replace all occurrences of TickQuiesced() with Tick():

// Before
rawNode.TickQuiesced()

// After
rawNode.Tick()

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: soma00333
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @soma00333. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@soma00333 soma00333 force-pushed the breaking-change-remove-tickquiesced branch from 2dc2c6c to 4a66f91 Compare November 17, 2024 05:44
@soma00333
Copy link
Author

@ahrtr
Hello. This is my first time contributing to etcd-io/raft.
I handled a ticket in the v4.0.0 milestone. Please let me know if you have any updates on the release status of v3.6.0 (If there are any critical blockers, I would like to help).
Thank you.

@ahrtr
Copy link
Member

ahrtr commented Nov 17, 2024

Thanks for raising this PR. We haven't cut release-3.6 branch yet. Will approve & merge this PR once it's done.

@soma00333
Copy link
Author

Thank you for checking and have a great weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants