Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/faucet attach 2 #269

Merged
merged 14 commits into from
Jan 4, 2021
Merged

Feat/faucet attach 2 #269

merged 14 commits into from
Jan 4, 2021

Commits on Dec 21, 2020

  1. main,ethclient,ethstats: init faucet attach feature

    Rel #258
    
    This begins implementation of the ref'd feature proposal.
    
    Currently 'ethstats' support is removed because
    that package relies heavily on access to a *node.Node.
    Eventually I want to move that packages demands to
    something that can be satisfied by an API instead.
    
    Date: 2020-12-21 12:16:33-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    02cee32 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2020

  1. Merge branch 'master' into feat/faucet-attach

    Conflicts:
    	cmd/faucet/faucet.go
    meowsbits committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    f27c029 View commit details
    Browse the repository at this point in the history
  2. ethstats: revert to use consensus.Engine interface

    I'm reverting the HeaderAuthorGetter interface
    solely to reduce diff size and complexity, both
    for this PR and in general.
    
    It doesn't mean I like it.
    
    Date: 2020-12-28 07:47:24-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    98d34f7 View commit details
    Browse the repository at this point in the history
  3. main: handle TODOs around faucet attachery

    Work was pending resolution of ethstats reporting
    in conjunction with node attaching.
    
    This has been resolved conceptually by
    make them exclusive; you cannot activate ethstats
    for the faucet's target attach node (since that
    node can handle ethstats reporting all by itself).
    
    Date: 2020-12-28 08:05:24-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    fac6afb View commit details
    Browse the repository at this point in the history
  4. main: fix typo in conditional decl

    Date: 2020-12-28 08:08:25-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    95fb625 View commit details
    Browse the repository at this point in the history
  5. main: create flag use audit function

    Make sure flags aren't used in impossible ways.
    
    Date: 2020-12-28 08:17:13-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    cfe8179 View commit details
    Browse the repository at this point in the history
  6. main: add flag exclusive case to audit (-genesis, -attach)

    Date: 2020-12-28 08:24:18-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    1c1e22e View commit details
    Browse the repository at this point in the history
  7. main: add info log lines around genesis/attach features

    Date: 2020-12-28 08:25:09-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    84e9391 View commit details
    Browse the repository at this point in the history
  8. ethstats: revert unrelated changes

    Date: 2020-12-28 08:37:41-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    dfdc5d8 View commit details
    Browse the repository at this point in the history
  9. ethstats: (lint) goimports

    Date: 2020-12-28 10:10:51-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    0962062 View commit details
    Browse the repository at this point in the history
  10. main: disable NoDiscovery (enable discovery)

    Faucet behavior previously effectively demanded
    user configuration of bootnodes manually
    to enable peering.
    
    This disables NoDiscovery, thus
    enabling discovery.
    
    Date: 2020-12-28 10:19:05-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    c99ed45 View commit details
    Browse the repository at this point in the history
  11. main: (lint) goimports

    Date: 2020-12-28 10:22:20-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    dc81ae8 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. main: configure datadir with genesis hash too

    As noted in the comment on line 310, when
    attaching to a remote client it may be that the
    API says that chain id is 0 when the client
    is not yet synced past the EIP155 activation
    block height.
    
    Requesting and switching on the genesis block
    hash fixes this issue except for the foundation/classic
    corner case (same genesis, different chain ids).
    
    Date: 2020-12-29 05:14:04-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    b780748 View commit details
    Browse the repository at this point in the history
  2. main: add -attach.chainid to provide accessible fallback value

    This value would be useful and necessary only if
    the target client were unsynced past the EIP155
    activation height.
    
    ChainID is used to disambiguate ETH/ETC chains.
    
    Date: 2020-12-29 05:30:04-06:00
    Signed-off-by: meows <[email protected]>
    meowsbits committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    e383405 View commit details
    Browse the repository at this point in the history