Skip to content
This repository has been archived by the owner on Feb 27, 2021. It is now read-only.

handle bigInt with maxBy and minBy #439

Closed
shanejonas opened this issue Nov 7, 2020 · 3 comments · Fixed by #441
Closed

handle bigInt with maxBy and minBy #439

shanejonas opened this issue Nov 7, 2020 · 3 comments · Fixed by #441
Labels
released

Comments

@shanejonas
Copy link
Contributor

for calculating things like gasPrice min/maxes we are just using lodash. but probably doesnt support BigInt
@shanejonas
Copy link
Contributor Author

image

seems like its just breaking prod

to reproduce go here:

https://expedition.dev/block/0x2eced4422d3146112c43a17a882cfb539d0a450602c7f73d9a216c68b589b545?network=ethereum

shanejonas added a commit that referenced this issue Nov 9, 2020
@shanejonas
fix: handle bigint with maxBy and minBy
2070fe1 
fixes #439
@shanejonas shanejonas mentioned this issue Nov 9, 2020
Merged
@shanejonas
Copy link
Contributor Author

🎉 This issue has been resolved in version 1.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle bigint with maxBy and minBy etclabscore/expedition
2 participants
@shanejonas and others