Skip to content
This repository has been archived by the owner on Feb 27, 2021. It is now read-only.

deep links dont work with github pages #73

Closed
shanejonas opened this issue Sep 17, 2019 · 1 comment · Fixed by #74
Closed

deep links dont work with github pages #73

shanejonas opened this issue Sep 17, 2019 · 1 comment · Fixed by #74
Labels
bug Something isn't working released

Comments

@shanejonas
Copy link
Contributor

Describe the bug
deep links dont work with github pages

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://explorer.jade.builders/block/0x059fcf633edbc2c7a17c443bb49532abd2b8960f99221dd4b6a82a10ed0c3fbc
  2. See 404 error

Expected behavior
I expect to be deep linked to a block

Screenshots
image

Additional context
facebook/create-react-app#1765 (comment)
@shanejonas shanejonas added the bug Something isn't working label Sep 17, 2019
shanejonas added a commit that referenced this issue Sep 17, 2019
@shanejonas
fix(gh-pages): deep links for react github pages
7bc466b 
fixes #73
@shanejonas shanejonas mentioned this issue Sep 17, 2019
Merged
shanejonas pushed a commit that referenced this issue Sep 17, 2019
@semantic-release-bot
chore(release): 1.1.1 [skip ci]
a3c2ee7 
## [1.1.1](1.1.0...1.1.1) (2019-09-17)

### Bug Fixes

* **dashboard:** remove "No" text when not syncing ([3c3acc9](3c3acc9)), closes [#65](#65)
* **gh-pages:** deep links for react github pages ([7bc466b](7bc466b)), closes [#73](#73)
* small screen cleanup ([9c7e47b](9c7e47b)), closes [#70](#70)
@shanejonas
Copy link
Contributor Author

🎉 This issue has been resolved in version 1.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gh-pages): deep links for react github pages etclabscore/expedition
1 participant
@shanejonas