This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Makefile and README updates #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soc1c
reviewed
Jun 10, 2019
|
do we still need the old readme? otherwise looks good |
Was suggested by Greg to keep old, but I don't see the need if this codebase will not replace the one at ethereumproject/ |
|
well, commits can be reverted, so technically the old is always still around |
Open
GregTheGreek
previously requested changes
Jun 11, 2019
|
Can we merge this? I also want to work on these files asap. |
noot
approved these changes
Jun 11, 2019
I was going to make a couple more changes regarding go modules including adding GO111MODULE=on flag to all go commands. I can do this in another branch if you would like to merge this in. |
|
No, go ahead. I'll do this tomorrow then. |
I'm done with this now, unless changes are requested. |
steviezhang
approved these changes
Jun 11, 2019
soc1c
approved these changes
Jun 12, 2019
This was referenced Jun 13, 2019
dziabko
pushed a commit
that referenced
this pull request
Jun 20, 2019
* wip makefile updates * Fixed makefile and updated README * Fixed readme changes * Added go module documentation and fixed wiki links to EP * Added go modules on for makefile commands and documentation
dziabko
pushed a commit
that referenced
this pull request
Jun 20, 2019
* wip makefile updates * Fixed makefile and updated README * Fixed readme changes * Added go module documentation and fixed wiki links to EP * Added go modules on for makefile commands and documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation and makefile, please try to run the commands and makefile to make sure everything is working. I wasn't very thorough and didn't completely rewrite the README to keep their general structure but please feel free to contribute or suggest what it should look like.