This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
cmd/geth rename client #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
reviewed
Jun 10, 2019
| @@ -458,7 +458,7 @@ func MakePasswordList(ctx *cli.Context) []string { | |||
|
|
|||
| // makeName makes the node name, which can be (in part) customized by the NodeNameFlag | |||
| func makeNodeName(version string, ctx *cli.Context) string { | |||
| name := fmt.Sprintf("Geth/%s/%s/%s", version, runtime.GOOS, runtime.Version()) | |||
| name := fmt.Sprintf("Getc/%s/%s/%s", version, runtime.GOOS, runtime.Version()) | |||
There was a problem hiding this comment.
Typo as Gethc? Does this have a functional difference or just used for logging in the CLI?
There was a problem hiding this comment.
G-ETH and G-ETC, just wanted to keep it short :)
This is the name the node reports
There was a problem hiding this comment.
ohh gotcha, yeah that makes sense
GregTheGreek
approved these changes
Jun 11, 2019
austinabell
approved these changes
Jun 11, 2019
noot
approved these changes
Jun 12, 2019
dziabko
pushed a commit
that referenced
this pull request
Jun 20, 2019
dziabko
pushed a commit
that referenced
this pull request
Jun 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.