URIDecode Query String Before Validating Query #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested this on on firefox and postman and it works. Applications such as postman encodeURI before sending it out. This will decode it before evaluating it. I would ask to implement this or create a option to atleast set this if needed. In anycase a simple decode won't hurt the tool. Only make it before at the least.
|
Closing. See comment ethanresnick/json-api#187 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards to issue #4
I tested this on on firefox and postman and it works. Applications such as postman encodeURI before sending it out. This will decode the query string before validating the string. I would ask to implement this or create a option to at least set this if needed. In any case a simple decode won't hurt the tool. Only make it better at the least.