Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ethash to make go-ethereum hive work #81

Merged

Conversation

pcw109550
Copy link

@pcw109550 pcw109550 commented May 3, 2023

Description

Hive CI is failing due to ethash removal in go-ethereum. See ethereum/go-ethereum#27178.

Fix L1 go-ethereum hive docker init by removing ethash verification cache at Dockerfile and also miner.threads flag in entrypoint.

Tests

This PR mirrors testinprod-io#7. CI passing again!

Additional context

This fix may also needed to https://github.com/ethereum/hive.

Copy link

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you.

@ajsutton ajsutton merged commit 2c8dba5 into ethereum-optimism:optimism May 4, 2023
Copy link

@Abeanna Abeanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants