Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently use uint64 for Holocene eip-1559 params #406

Open
wants to merge 1 commit into
base: optimism
Choose a base branch
from

Conversation

roberto-bayardo
Copy link
Contributor

Description

We were unnecessarily exposing the fact that these parameters were being encoded as uint32. Changing to always use uint64 outside of the encode/decode abstractions.

Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But now the parameters might be corrupted if they're too large. The caller explicitly casting these fixes that, to put the burden on the caller.
Alternatively, maybe add a doc comment about valid range, and assert with a panic the input isn't too large?

@roberto-bayardo roberto-bayardo force-pushed the uint64-for-1559-params branch 2 times, most recently from f9062a9 to b8903af Compare October 18, 2024 19:50
@roberto-bayardo
Copy link
Contributor Author

roberto-bayardo commented Oct 18, 2024

But now the parameters might be corrupted if they're too large. The caller explicitly casting these fixes that, to put the burden on the caller. Alternatively, maybe add a doc comment about valid range, and assert with a panic the input isn't too large?

good suggestion, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants