maint(ct): add leftover interfaces #12167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
packages/contracts-bedrock/src/universal/interfaces/IProxyAdmin.sol
Outdated
Show resolved
Hide resolved
smartcontracts
force-pushed
the
sc/ct-leftover-interfaces
branch
3 times, most recently
from
fd368ff
to
0d8b5b3
Compare
Adds a few remaining interfaces required before we can migrate OPCM to use interfaces over source contracts.
smartcontracts
force-pushed
the
sc/ct-leftover-interfaces
branch
from
0d8b5b3
to
8a0bca3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12167 +/- ##
===========================================
- Coverage 75.19% 74.97% -0.22%
===========================================
Files 49 49
Lines 3656 3656
===========================================
- Hits 2749 2741 -8
- Misses 734 743 +9
+ Partials 173 172 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
AmadiMichael
approved these changes
Sep 27, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Adds a few remaining interfaces required before we can migrate OPCM to use interfaces over source contracts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few remaining interfaces required before we can migrate OPCM to use interfaces over source contracts.
Closes #11686