Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups for production, add standard addresses #12169

Merged
merged 16 commits into from
Sep 27, 2024
Merged

Conversation

mslipper
Copy link
Collaborator

This PR:

  • Cleans up the intent file to be more suitable for production deployments
  • Fixes various bugs encountered while preparing op-deployer for use against predeployed OPCM contracts
  • Adds a new CLI command to bootstrap a new OPCM deployment against an existing set of implementation contracts

Note on Solidity changes:

  • Since the code for custom gas tokens is in the monorepo but isn't included in an official contracts release yet, we had to add interfaces for the pre-CGT contracts to the Solidity codebase.
  • The DeployImplementations script looks at the release identifier to determine whether or not it should use the pre- or post-CGT interfaces.

This PR:

- Cleans up the intent file to be more suitable for production deployments
- Fixes various bugs encountered while preparing `op-deployer` for use against predeployed OPCM contracts
- Adds a new CLI command to bootstrap a new OPCM deployment against an existing set of implementation contracts

Note on Solidity changes:

- Since the code for custom gas tokens is in the monorepo but isn't included in an official contracts release yet, we had to add interfaces for the pre-CGT contracts to the Solidity codebase.
- The `DeployImplementations` script looks at the release identifier to determine whether or not it should use the pre- or post-CGT interfaces.
@mslipper mslipper requested review from a team as code owners September 27, 2024 05:13
Copy link
Contributor

semgrep-app bot commented Sep 27, 2024

Semgrep found 12 sol-deployutils-args findings:

_args parameter should be wrapped with DeployUtils.encodeConstructor

Ignore this finding from sol-deployutils-args.

@mslipper mslipper removed this pull request from the merge queue due to a manual request Sep 27, 2024
@mslipper mslipper added this pull request to the merge queue Sep 27, 2024
Copy link
Contributor

@axelKingsley axelKingsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review focused on the modification to the TxManager's increaseGasPrice function. Seems like a sound change, but called out some things we could do in the future for it.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@mslipper mslipper added this pull request to the merge queue Sep 27, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2024
* Cleanups for production, add standard addresses

This PR:

- Cleans up the intent file to be more suitable for production deployments
- Fixes various bugs encountered while preparing `op-deployer` for use against predeployed OPCM contracts
- Adds a new CLI command to bootstrap a new OPCM deployment against an existing set of implementation contracts

Note on Solidity changes:

- Since the code for custom gas tokens is in the monorepo but isn't included in an official contracts release yet, we had to add interfaces for the pre-CGT contracts to the Solidity codebase.
- The `DeployImplementations` script looks at the release identifier to determine whether or not it should use the pre- or post-CGT interfaces.

* goimports

* lints

* fix tests

* revert tx manger changes

* Update packages/contracts-bedrock/src/L1/interfaces/IL1StandardBridgeV160.sol

Co-authored-by: Maurelian <[email protected]>

* Update packages/contracts-bedrock/src/L1/interfaces/IL1CrossDomainMessengerV160.sol

Co-authored-by: Maurelian <[email protected]>

* use new opcm

* fix test

* semver

* semver

* bump semver

* update manager deployment

* natspec

* SEMVER

---------

Co-authored-by: Maurelian <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@mslipper mslipper added this pull request to the merge queue Sep 27, 2024
@axelKingsley
Copy link
Contributor

Merged via the queue into develop with commit 644dc2b Sep 27, 2024
61 of 62 checks passed
@mslipper mslipper deleted the feat/sepolia-deployment branch September 27, 2024 21:34
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
)

* Cleanups for production, add standard addresses

This PR:

- Cleans up the intent file to be more suitable for production deployments
- Fixes various bugs encountered while preparing `op-deployer` for use against predeployed OPCM contracts
- Adds a new CLI command to bootstrap a new OPCM deployment against an existing set of implementation contracts

Note on Solidity changes:

- Since the code for custom gas tokens is in the monorepo but isn't included in an official contracts release yet, we had to add interfaces for the pre-CGT contracts to the Solidity codebase.
- The `DeployImplementations` script looks at the release identifier to determine whether or not it should use the pre- or post-CGT interfaces.

* goimports

* lints

* fix tests

* revert tx manger changes

* Update packages/contracts-bedrock/src/L1/interfaces/IL1StandardBridgeV160.sol

Co-authored-by: Maurelian <[email protected]>

* Update packages/contracts-bedrock/src/L1/interfaces/IL1CrossDomainMessengerV160.sol

Co-authored-by: Maurelian <[email protected]>

* use new opcm

* fix test

* semver

* semver

* bump semver

* update manager deployment

* natspec

* SEMVER

---------

Co-authored-by: Maurelian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants