packages/contracts-bedrock: make check-interfaces.sh warn on old versions of bash #12220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
warn-old-bash
branch
from
f37c614
to
dd5a325
Compare
tynes
approved these changes
Oct 1, 2024
clabby
approved these changes
Oct 1, 2024
|
Issue with external contributions right now, reverting a recent change: #12227 |
|
Should be ready to merge if you rebase now |
roberto-bayardo
force-pushed
the
warn-old-bash
branch
from
a6a17de
to
57c3168
Compare
done |
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 1, 2024
dd2b21c
58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The check-interfaces.sh script has become incredibly slow (like 10+ minutes slow) on Mac OSX due to its antiquated default bash installation, so this PR adds a warning on old bash versions informing the caller to upgrade bash if there are performance issues.