-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ctb): no refunds #3535
feat(ctb): no refunds #3535
Conversation
🦋 Changeset detectedLatest commit: fb3327c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
700c392
to
8a96412
Compare
4086f51
to
ff75e3a
Compare
packages/contracts-bedrock/contracts/universal/StandardBridge.sol
Outdated
Show resolved
Hide resolved
ff75e3a
to
ad8aa8e
Compare
Needs a regenerated snapshot |
ad8aa8e
to
5fa8b4a
Compare
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
5fa8b4a
to
d20e40c
Compare
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
d20e40c
to
423f58d
Compare
423f58d
to
32f3a77
Compare
Codecov ReportBase: 23.32% // Head: 23.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #3535 +/- ##
===========================================
+ Coverage 23.32% 23.53% +0.21%
===========================================
Files 335 335
Lines 33993 33672 -321
Branches 136 133 -3
===========================================
- Hits 7929 7926 -3
+ Misses 25125 24806 -319
- Partials 939 940 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
32f3a77
to
6f24049
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
This is going to need a rebase, will review afterwards |
Removes refunds from the StandardBridge flow.
6f24049
to
d71922d
Compare
Will need a follow up PR that removes this functionality from the NFT bridge |
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
Looks like another PR was merged, needs another rebase |
I'll take care of it |
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
What's the rationale behind the decision to remove refunds out of the bridge? |
Description
Removes refunds from the StandardBridge flow.
Tests
Removes tests related to refund logic.