Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-e2e: pending block test + op-geth update #5736

Merged
merged 5 commits into from
May 26, 2023
Merged

Conversation

protolambda
Copy link
Contributor

@protolambda protolambda commented May 18, 2023

Description

Tests that the pending block matches the latest block, a change introduced in ethereum-optimism/op-geth#93

Added a temporary go.mod change so it runs CI with that op-geth PR. We should merge the geth PR first, and then update the go.mod to point at the main branch. Matches latest optimism branch op-geth commit now (previous v1.11.6 changes were included before this PR already, and don't really affect the op-node other than e2e testing, this strictly introduces the receipt L1-fee overhead metadata fix and the pending-block change).

@protolambda protolambda requested a review from a team as a code owner May 18, 2023 14:44
@protolambda protolambda requested a review from tynes May 18, 2023 14:44
@changeset-bot
Copy link

changeset-bot bot commented May 18, 2023

⚠️ No Changeset found

Latest commit: 6fc9a72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 6fc9a72
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/647128b48709400008c8257b

@protolambda protolambda force-pushed the pending-block-test branch 2 times, most recently from 03e6761 to 57e39b0 Compare May 18, 2023 21:28
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against this as-is but I worry a bit about the race conditions involved with assertions about the pending block when we aren't controlling block building timing.

op-e2e/system_test.go Show resolved Hide resolved
op-e2e/system_test.go Show resolved Hide resolved
@protolambda
Copy link
Contributor Author

  • rebased on develop
  • updated op-geth reference to latest
  • updated e2e tests for receipt metadata fields

Will look into adding the additional geth tests now, but think we can also choose to merge with current tests as-is if there is any urgency, since it covers the pending-block behavior, and we also already did an internal devnet test (see notion doc).

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #5736 (6fc9a72) into develop (a2b038e) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5736   +/-   ##
========================================
  Coverage    42.27%   42.28%           
========================================
  Files          464      464           
  Lines        30078    30078           
  Branches       876      876           
========================================
+ Hits         12716    12719    +3     
+ Misses       16360    16359    -1     
+ Partials      1002     1000    -2     
Flag Coverage Δ
bedrock-go-tests 39.71% <ø> (+0.01%) ⬆️
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 53.51% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 29.33% <ø> (ø)
sdk-tests 39.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@protolambda
Copy link
Contributor Author

protolambda commented May 26, 2023

  • Added test for pending block result at every stage of Engine API
  • Added TODOs for every usage of -1 as pending-block identifier in ethclient. Once we update op-geth with upstream changes we can cleanly import the geth rpc label vars.
  • Edit: and fixed lint

@protolambda protolambda changed the title op-e2e: pending block test op-e2e: pending block test + op-geth update May 26, 2023
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Contributor

mergify bot commented May 26, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 26, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 26, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 9b3cfbe into develop May 26, 2023
@OptimismBot OptimismBot deleted the pending-block-test branch May 26, 2023 22:02
@mergify mergify bot removed the on-merge-train label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants