Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannon: Fix unaligned pre-image key writes in Go VM #6191

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

Inphi
Copy link
Contributor

@Inphi Inphi commented Jun 29, 2023

Fixes a mips.go bug where pre-image key writes from unaligned memory would always start at the aligned offset.

For example, given a buffer containing 0xdeADbeEF (big-endian) located at 0x32000001, writing 1 byte to the pre-image request stream should only write a 0xAD value.

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2023

⚠️ No Changeset found

Latest commit: d36bdd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Inphi Inphi requested a review from protolambda June 29, 2023 03:20
@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit d36bdd3
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/649dcc9d9cdcea0008fcc102

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #6191 (9663adb) into develop (add32f6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6191      +/-   ##
===========================================
+ Coverage    44.68%   44.69%   +0.01%     
===========================================
  Files          448      448              
  Lines        29383    29383              
  Branches       691      691              
===========================================
+ Hits         13129    13133       +4     
+ Misses       15184    15182       -2     
+ Partials      1070     1068       -2     
Flag Coverage Δ
bedrock-go-tests 43.59% <ø> (+0.01%) ⬆️
cannon-go-tests 61.78% <100.00%> (+0.07%) ⬆️
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 58.75% <ø> (ø)
core-utils-tests 49.06% <ø> (ø)
fault-detector-tests 26.95% <ø> (ø)
sdk-tests 42.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cannon/mipsevm/mips.go 92.25% <100.00%> (+0.22%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

- Also adds a test asserting faulting behavior for illegal instructions
@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 08d44ae into develop Jun 29, 2023
@OptimismBot OptimismBot deleted the inphi/cannon-test branch June 29, 2023 18:28
@mergify mergify bot removed the on-merge-train label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants