-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannon: Fix unaligned pre-image key writes in Go VM #6191
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #6191 +/- ##
===========================================
+ Coverage 44.68% 44.69% +0.01%
===========================================
Files 448 448
Lines 29383 29383
Branches 691 691
===========================================
+ Hits 13129 13133 +4
+ Misses 15184 15182 -2
+ Partials 1070 1068 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice find!
- Also adds a test asserting faulting behavior for illegal instructions
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Fixes a mips.go bug where pre-image key writes from unaligned memory would always start at the aligned offset.
For example, given a buffer containing
0xdeADbeEF
(big-endian) located at0x32000001
, writing 1 byte to the pre-image request stream should only write a0xAD
value.