feat: Add gas estimation utilities #6267

roninjin10 · 2023-07-12T07:58:29Z

Add simple gas estimation tools such as the ability to estimate l1 gas with a minimal api
This replaces l2Provider.ts version which was tightly coupled to ethers.js. This one you don't even realize you are using viem as the API is minimal
Don't document this as it's a one off tool and the plan is to make normal tools "just work"
- we should document it in a guide/tutorial instead after this lands

changeset-bot · 2023-07-12T07:58:32Z

⚠️ No Changeset found

Latest commit: 5a817f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

roninjin10 · 2023-07-12T07:58:40Z

Current dependencies on/for this PR:

develop
- PR feat: Add ts contract package for TS #6260
  - PR feat: Add contracts-periphery to contracts-ts #6298
  - PR feat: Add gas estimation utilities #6267 👈
    - PR test: Add ci check for gas-estimation package #6407
      - PR feat: Add address.json generation to contracts-bedrock #6301

This comment was auto-generated by Graphite.

codecov · 2023-07-12T08:42:57Z

Codecov Report

Merging #6267 (3753b5c) into 07-11-feat_Add_ts_contract_package_for_TS (8087e2b) will decrease coverage by 1.09%.
The diff coverage is n/a.

❗ Current head 3753b5c differs from pull request most recent head c4bb3a3. Consider uploading reports for the commit c4bb3a3 to get more accurate results

Additional details and impacted files

@@                              Coverage Diff                              @@
##           07-11-feat_Add_ts_contract_package_for_TS    #6267      +/-   ##
=============================================================================
- Coverage                                      44.53%   43.44%   -1.09%     
=============================================================================
  Files                                            437      306     -131     
  Lines                                          29081    24315    -4766     
  Branches                                         712        0     -712     
=============================================================================
- Hits                                           12950    10564    -2386     
+ Misses                                         15062    12754    -2308     
+ Partials                                        1069      997      -72

Flag	Coverage Δ
bedrock-go-tests	`43.44% <ø> (+0.01%)`	⬆️
cannon-go-tests	`?`
common-ts-tests	`?`
contracts-bedrock-tests	`?`
core-utils-tests	`?`
fault-detector-tests	`?`
sdk-next-tests	`?`
sdk-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 134 files with indirect coverage changes

packages/contracts-ts/src/estimateGas.ts

mergify · 2023-07-12T11:31:31Z

Hey @roninjin10! This PR has merge conflicts. Please fix them before continuing review.

tynes

These utilities should go in core utils

nickbalestra

LGTM!

packages/fee-estimation/LICENSE

roninjin10 · 2023-07-20T20:00:32Z

git in shambles

mergify · 2023-07-20T23:01:39Z

Hey @roninjin10! This PR has merge conflicts. Please fix them before continuing review.

feat: Add feeEstimation function and move to correct package Apply suggestions from code review Co-authored-by: Annie Ke <[email protected]> fix: Remove the copy pasta from package.json Update packages/fee-estimation/README.md feat: Offer passing in viem client as an option better api and tests better docs all the docs fix: Make viem a peer dep typo fix: Refactor to use viem correctly (docs not updated yet) moar tests more explicit implementations Update packages/fee-estimation/src/estimateFees.ts fix: lint fix: Remove bad import and debugging fs.writeFile chore: pnpm up --latest packages feat: Add zora and base mainnet fix: linter

roninjin10 · 2023-07-21T23:27:18Z

Moved ci check into it's own pr so the devops folks who might already be off for the weekend aren't blocking review #6407

mergify · 2023-07-21T23:42:32Z

This PR has been added to the merge queue, and will be merged soon.

mergify · 2023-07-21T23:42:33Z

This PR is next in line to be merged, and will be merged as soon as checks pass.

This was referenced Jul 12, 2023

fix(sdk): Add missing message status index #6254

Merged

feat: Add ts contract package for TS #6260

Merged

roninjin10 force-pushed the 07-11-feat_Add_ts_contract_package_for_TS branch from f4a25b6 to e2d3fb0 Compare July 12, 2023 08:02

roninjin10 force-pushed the willc/gas-estimation branch from 4b7f9bc to 6ecd446 Compare July 12, 2023 08:02

roninjin10 force-pushed the 07-11-feat_Add_ts_contract_package_for_TS branch from e2d3fb0 to f0af6c9 Compare July 12, 2023 08:03

roninjin10 force-pushed the willc/gas-estimation branch from 6ecd446 to 441a65e Compare July 12, 2023 08:03

roninjin10 force-pushed the 07-11-feat_Add_ts_contract_package_for_TS branch from f0af6c9 to 6431ffb Compare July 12, 2023 08:09

roninjin10 force-pushed the willc/gas-estimation branch from 441a65e to 06954fe Compare July 12, 2023 08:09

roninjin10 force-pushed the 07-11-feat_Add_ts_contract_package_for_TS branch from 6431ffb to 5fb79b4 Compare July 12, 2023 08:12

roninjin10 force-pushed the willc/gas-estimation branch from 06954fe to b42414c Compare July 12, 2023 08:13

roninjin10 force-pushed the 07-11-feat_Add_ts_contract_package_for_TS branch from 5fb79b4 to e2c0d73 Compare July 12, 2023 08:14

roninjin10 force-pushed the willc/gas-estimation branch from b42414c to 54dd535 Compare July 12, 2023 08:15

roninjin10 force-pushed the 07-11-feat_Add_ts_contract_package_for_TS branch from e2c0d73 to 6175b77 Compare July 12, 2023 08:16

roninjin10 force-pushed the willc/gas-estimation branch from 54dd535 to d7ef698 Compare July 12, 2023 08:16

roninjin10 force-pushed the 07-11-feat_Add_ts_contract_package_for_TS branch from 6175b77 to 3912f3a Compare July 12, 2023 08:28

roninjin10 force-pushed the willc/gas-estimation branch from d7ef698 to 57bbbbc Compare July 12, 2023 08:28

roninjin10 force-pushed the 07-11-feat_Add_ts_contract_package_for_TS branch from 3912f3a to 26d73c3 Compare July 12, 2023 08:28

roninjin10 force-pushed the willc/gas-estimation branch from 57bbbbc to 3753b5c Compare July 12, 2023 08:28

roninjin10 commented Jul 12, 2023

View reviewed changes

packages/contracts-ts/src/estimateGas.ts Outdated Show resolved Hide resolved

roninjin10 commented Jul 12, 2023

View reviewed changes

packages/contracts-ts/src/estimateGas.ts Outdated Show resolved Hide resolved

roninjin10 commented Jul 12, 2023

View reviewed changes

packages/contracts-ts/src/estimateGas.ts Outdated Show resolved Hide resolved

roninjin10 force-pushed the willc/gas-estimation branch from 3753b5c to c4bb3a3 Compare July 12, 2023 11:30

mergify bot added the conflict label Jul 12, 2023

roninjin10 force-pushed the 07-11-feat_Add_ts_contract_package_for_TS branch from 26d73c3 to f0474d4 Compare July 12, 2023 11:36

mergify bot removed the conflict label Jul 12, 2023

tynes reviewed Jul 12, 2023

View reviewed changes

roninjin10 requested a review from jxom July 20, 2023 05:44

hamdiallam approved these changes Jul 20, 2023

View reviewed changes

nickbalestra approved these changes Jul 20, 2023

View reviewed changes

packages/fee-estimation/LICENSE Show resolved Hide resolved

roninjin10 force-pushed the willc/gas-estimation branch 2 times, most recently from 98276c8 to 15a532c Compare July 20, 2023 19:57

roninjin10 requested review from a team as code owners July 20, 2023 19:57

mergify bot added A-indexer Area: indexer sdk labels Jul 20, 2023

roninjin10 force-pushed the willc/gas-estimation branch from 15a532c to 98276c8 Compare July 20, 2023 19:59

roninjin10 force-pushed the willc/gas-estimation branch from 98276c8 to b7986e6 Compare July 20, 2023 20:03

mergify bot added the conflict label Jul 20, 2023

roninjin10 force-pushed the willc/gas-estimation branch from b7986e6 to 09e124d Compare July 21, 2023 22:04

mergify bot removed the conflict label Jul 21, 2023

roninjin10 force-pushed the willc/gas-estimation branch 4 times, most recently from c3d4e47 to 2c74b97 Compare July 21, 2023 23:17

roninjin10 force-pushed the willc/gas-estimation branch from 2c74b97 to 5a817f1 Compare July 21, 2023 23:26

roninjin10 mentioned this pull request Jul 21, 2023

test: Add ci check for gas-estimation package #6407

Closed

OptimismBot merged commit f4411c5 into develop Jul 21, 2023

OptimismBot deleted the willc/gas-estimation branch July 21, 2023 23:42

mergify bot added on-merge-train and removed on-merge-train labels Jul 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add gas estimation utilities #6267

feat: Add gas estimation utilities #6267

roninjin10 commented Jul 12, 2023 •

edited

Loading

changeset-bot bot commented Jul 12, 2023 •

edited

Loading

roninjin10 commented Jul 12, 2023 •

edited

Loading

codecov bot commented Jul 12, 2023 •

edited

Loading

mergify bot commented Jul 12, 2023

tynes left a comment

nickbalestra left a comment

roninjin10 commented Jul 20, 2023

mergify bot commented Jul 20, 2023

roninjin10 commented Jul 21, 2023

mergify bot commented Jul 21, 2023

mergify bot commented Jul 21, 2023

feat: Add gas estimation utilities #6267

feat: Add gas estimation utilities #6267

Conversation

roninjin10 commented Jul 12, 2023 • edited Loading

changeset-bot bot commented Jul 12, 2023 • edited Loading

⚠️ No Changeset found

roninjin10 commented Jul 12, 2023 • edited Loading

codecov bot commented Jul 12, 2023 • edited Loading

Codecov Report

mergify bot commented Jul 12, 2023

tynes left a comment

Choose a reason for hiding this comment

nickbalestra left a comment

Choose a reason for hiding this comment

roninjin10 commented Jul 20, 2023

mergify bot commented Jul 20, 2023

roninjin10 commented Jul 21, 2023

mergify bot commented Jul 21, 2023

mergify bot commented Jul 21, 2023

roninjin10 commented Jul 12, 2023 •

edited

Loading

changeset-bot bot commented Jul 12, 2023 •

edited

Loading

roninjin10 commented Jul 12, 2023 •

edited

Loading

codecov bot commented Jul 12, 2023 •

edited

Loading