Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code examples in README #6873

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Conversation

spacesailor24
Copy link
Contributor

In README:

  • Renames OptimismFeeEstimationPlugin to OptimismPlugin
  • Adds plugin registration step to estimateFees code example

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #6873 (fdab6ca) into develop (4bb2e6c) will increase coverage by 5.88%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6873      +/-   ##
===========================================
+ Coverage    44.81%   50.69%   +5.88%     
===========================================
  Files          376      314      -62     
  Lines        29535    23665    -5870     
  Branches      1692        0    -1692     
===========================================
- Hits         13235    11997    -1238     
+ Misses       14858    10621    -4237     
+ Partials      1442     1047     -395     
Flag Coverage Δ
bedrock-go-tests 47.80% <ø> (-0.03%) ⬇️
cannon-go-tests 64.18% <ø> (ø)
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests ∅ <ø> (∅)
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 64 files with indirect coverage changes

@clabby clabby added M-docs Meta: documentation related A-pkg-web3js-plugin Area: packages/web3js-plugin labels Aug 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot added the S-on-merge-train Status: This PR is in the merge queue label Aug 17, 2023
@OptimismBot OptimismBot merged commit 5d1a445 into develop Aug 17, 2023
7 checks passed
@OptimismBot OptimismBot deleted the wyatt/web3js-plugin/update-readme branch August 17, 2023 19:17
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the S-on-merge-train Status: This PR is in the merge queue label Aug 17, 2023
@github-actions github-actions bot mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pkg-web3js-plugin Area: packages/web3js-plugin M-docs Meta: documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants