Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

[feature] Bot should allow non-EIP changes #5

Closed
lightclient opened this issue Jun 18, 2021 · 1 comment
Closed

[feature] Bot should allow non-EIP changes #5

lightclient opened this issue Jun 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@lightclient
Copy link
Member

After 1 editor approval, the bot should allow non-EIP changes like to the pages infra. See this PR as an example: ethereum/EIPs#3581

@alita-moore alita-moore changed the title Bot should allow non-EIP changes [bug] Bot should allow non-EIP changes Jul 25, 2021
@alita-moore alita-moore added the bug Something isn't working label Jul 25, 2021
@alita-moore alita-moore changed the title [bug] Bot should allow non-EIP changes [feature] Bot should allow non-EIP changes Jul 25, 2021
@alita-moore alita-moore added enhancement New feature or request and removed bug Something isn't working labels Jul 25, 2021
@alita-moore
Copy link
Contributor

alita-moore commented Nov 22, 2021

This is accomplished by b9e9330

(details included in commit comments)
This implements a few features:

  • eip authors can also make changes to the assets file which will allow any changes so long as the eip passes; i.e. I can do whatever I want to assets/eip-2/.. if I (at the same time) make changes to EIPs/eip-2.md and that is eligible for auto-merge.
  • if an editor approves then any non eip file will pass

I also made a few cleanups

  • better error handling
  • cleaner code
  • more tests
  • conitnuing transition to class based approach (I'm converting old style to new style whenever I make changes to that file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants