Remove Outdated Assertions #109
Conversation
|
@MicahZoltu I request your "submit review"-clicking prowess. |
|
Please get a review from another editor. I don't feel comfortable deciding what is/isn't appropriate to merge as I'm no longer an editor. |
|
CC @JEAlfonsoP, but @MicahZoltu you are the only person that has the ability to merge. Actually, I guess @axic does. |
|
I don't mind clicking the button once there is approval from other editors, but I don't want to be the one deciding to click the button. |
| @@ -33,5 +33,5 @@ inputs: | |||
| runs: | |||
| using: "composite" | |||
| steps: | |||
| - run: cd ${{github.action_path}} && yarn install && yarn build && ERC_EDITORS=${{ inputs.ERC_EDITORS }} CORE_EDITORS=${{ inputs.CORE_EDITORS }} NETWORKING_EDITORS=${{ inputs.NETWORKING_EDITORS }} INTERFACE_EDITORS=${{ inputs.INTERFACE_EDITORS }} META_EDITORS=${{ inputs.META_EDITORS }} INFORMATIONAL_EDITORS=${{ inputs.INFORMATIONAL_EDITORS }} GITHUB_TOKEN=${{ inputs.GITHUB-TOKEN }} MAINTAINERS=${{ inputs.MAINTAINERS }} NODE_ENV=production node build/src/index.js | |||
| - run: cd ${{github.action_path}} && yarn install && yarn build && ERC_EDITORS=${{ inputs.ERC_EDITORS }} CORE_EDITORS=${{ inputs.CORE_EDITORS }} NETWORKING_EDITORS=${{ inputs.NETWORKING_EDITORS }} INTERFACE_EDITORS=${{ inputs.INTERFACE_EDITORS }} META_EDITORS=${{ inputs.META_EDITORS }} INFORMATIONAL_EDITORS=${{ inputs.INFORMATIONAL_EDITORS }} GITHUB_TOKEN=${{ inputs.GITHUB-TOKEN }} MAINTAINERS=${{ inputs.MAINTAINERS }} PR_NUMBER=${{ inputs.PR_NUMBER }} NODE_ENV=production node build/src/index.js | |||
There was a problem hiding this comment.
Can we use the multiline syntax for this?
| - run: cd ${{github.action_path}} && yarn install && yarn build && ERC_EDITORS=${{ inputs.ERC_EDITORS }} CORE_EDITORS=${{ inputs.CORE_EDITORS }} NETWORKING_EDITORS=${{ inputs.NETWORKING_EDITORS }} INTERFACE_EDITORS=${{ inputs.INTERFACE_EDITORS }} META_EDITORS=${{ inputs.META_EDITORS }} INFORMATIONAL_EDITORS=${{ inputs.INFORMATIONAL_EDITORS }} GITHUB_TOKEN=${{ inputs.GITHUB-TOKEN }} MAINTAINERS=${{ inputs.MAINTAINERS }} PR_NUMBER=${{ inputs.PR_NUMBER }} NODE_ENV=production node build/src/index.js | |
| - run: | | |
| cd ${{github.action_path}} && \ | |
| yarn install && \ | |
| yarn build && \ | |
| ERC_EDITORS=${{ inputs.ERC_EDITORS }} \ | |
| CORE_EDITORS=${{ inputs.CORE_EDITORS }} \ | |
| NETWORKING_EDITORS=${{ inputs.NETWORKING_EDITORS }} \ | |
| INTERFACE_EDITORS=${{ inputs.INTERFACE_EDITORS }} \ | |
| META_EDITORS=${{ inputs.META_EDITORS }} \ | |
| INFORMATIONAL_EDITORS=${{ inputs.INFORMATIONAL_EDITORS }} \ | |
| GITHUB_TOKEN=${{ inputs.GITHUB-TOKEN }} \ | |
| MAINTAINERS=${{ inputs.MAINTAINERS }} \ | |
| PR_NUMBER=${{ inputs.PR_NUMBER }} \ | |
| NODE_ENV=production \ | |
| node build/src/index.js |
There was a problem hiding this comment.
Sounds good, but that should be done in a separate PR. This is known to work and this change would require re-testing.
There was a problem hiding this comment.
You're changing this code, so it's probably the best time to rework it.
Is testing it painful?
There was a problem hiding this comment.
Is testing it painful?
Very. Takes about 30 minutes to do a full E2E test, and it has to be done manually by two people simultaneously.
Blocking ethereum/EIPs#5400. It is safe to do this.