Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP1344 to be considered for next upgrade (Meta EIP1679) #1934

Closed
wants to merge 1 commit into from

Conversation

fubuloubu
Copy link
Contributor

Per the proposed process for handling EIPs for Hardforks (detailed here), we would like to propose EIP-1344 be formally considered for inclusion into the Istanbul hardfork (EIP-1679)

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • EIP 1679 requires approval from one of (@5chdn, @axic)

@poojaranjan
Copy link
Contributor

@fubuloubu Thanks for listing your EIP for consideration of Istanbul Upgrade. We've added it to the list of proposed EIPs for Istanbul here. As it appears, pull requests submitted here is monitored by bot and it requests for approval from author of EIP 1679 because of its mention.
So, it would be appropriate to create a new issue here, which eventually be closed after the EIP is added to the ‘EIPs for Upgrade’ list. The proposal #1929 is also updated accordingly.
Thanks for cooperation.

@fubuloubu
Copy link
Contributor Author

Closing this in favor of #1935 per @poojaranjan's recommendations.

@fubuloubu fubuloubu closed this Apr 11, 2019
@fubuloubu fubuloubu deleted the patch-2 branch April 11, 2019 21:35
@axic
Copy link
Member

axic commented Apr 12, 2019

I think we should merge this dependent on merging #1852. @fubuloubu do you want to reopen?

@fubuloubu
Copy link
Contributor Author

I deleted the branch so I can't reopen. But I will make a new one. Sorry for the inconvenience!

@axic
Copy link
Member

axic commented Apr 12, 2019

In the branches view of your fork you may be able to reinstate it. Opening a new PR however should not be an issue 😉

@fubuloubu
Copy link
Contributor Author

Re-opened at #1937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants